Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure AKS workflow #1563

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

mcollins-ttd
Copy link
Contributor

@mcollins-ttd mcollins-ttd commented Mar 13, 2025

  • Modify Azure workflow to create AKS deployment artifacts.
  • Use same Docker image for Azure Confidential Containers (CC) and AKS with Virtual Nodes on Azure Container Instances.
  • Delete the steps to create a release from the Azure workflow, as functionality is not needed.

@mcollins-ttd mcollins-ttd force-pushed the mkc-UID2-4765-aks-workflow-4 branch from dd0c617 to 99c4f90 Compare March 13, 2025 05:51
@mcollins-ttd mcollins-ttd marked this pull request as ready for review March 13, 2025 05:53
uses: actions/checkout@v4

- name: Install Azure CLI
uses: ./.github/actions/install_az_cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: IABTechLab/uid2-operator/.github/actions/install_az_cli to keep the repo consistent

uses: actions/checkout@v4

- name: Install Azure CLI
uses: ./.github/actions/install_az_cli
Copy link
Contributor

@cYKatherine cYKatherine Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: IABTechLab/uid2-operator/.github/actions/install_az_cli to keep the repo consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the downside to that, that it will run the action as it is on the default branch? Or if there's no such action on the default branch - like in this case - you'll get an error?

Copy link
Contributor Author

@mcollins-ttd mcollins-ttd Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also curious why our workflows call other workflows using ./.github/workflows/..., but our workflows calls actions using IABTechLab/uid2-operator/.github/actions/....

@@ -0,0 +1,20 @@
import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same file https://github.com/IABTechLab/uid2-operator/blob/main/scripts/azure-cc/deployment/generate.py 🤔 Maybe refer to that instead of creating a same duplicated file.

@mcollins-ttd mcollins-ttd force-pushed the mkc-UID2-4765-aks-workflow-4 branch from 49357bf to 64377e6 Compare March 13, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants