Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce problems in vs code tab due to spelling #594

Closed

Conversation

ashleysmithTTD
Copy link
Contributor

No description provided.

@@ -12,19 +12,19 @@ import EditParticipantDialog from './EditParticipantDialog';

import './ParticipantManagementItem.scss';

type ParticipantManagmentItemProps = Readonly<{
type ParticipantManagementItemProps = Readonly<{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management misspelling was causing a lot of errors

@@ -22,7 +22,7 @@ const apiKeyInitial = {
contact: 'ApiKey',
name: 'ApiKey',
created: 1702830516,
key_id: 'F4lfa.fdas',
key_id: 'F4lfa.test',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this key id to be gibberish if it can be a word, cspell was getting mad at this test key everywhere

{
"version": "0.2",
"language": "en",
"words": ["ssportal", "knexfile", "craco", "sendgrid", "typesafe", "tldts"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common portal words that cspell didnt know

@@ -107,7 +107,7 @@ describe('Key creation dialog', () => {

await enterApiName('key_name');

apiRoles.map(async (apiRole) => {
apiRoles.forEach(async (apiRole) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonarlint suggestion

@@ -57,7 +57,7 @@ export const MultipleRoles = () => {
);
};

export const KeyWithRolesParticipantIsntAllowed = () => {
export const KeyWithRolesParticipantIsNotAllowed = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didnt like isnt without an apostrophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant