Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce problems in vs code tab due to spelling #594

Closed
wants to merge 3 commits into from
Closed

Reduce problems in vs code tab due to spelling #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a2b9e5
fix management type
ashleysmithTTD Feb 12, 2025
e219c21
changed the test key to a real word
ashleysmithTTD Feb 12, 2025
1ae23c6
added cspell file with common portal abbreviations
ashleysmithTTD Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"version": "0.2",
"language": "en",
"words": ["ssportal", "knexfile", "craco", "sendgrid", "typesafe", "tldts"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common portal words that cspell didnt know

}
4 changes: 2 additions & 2 deletions src/web/components/ApiKeyManagement/KeyEditDialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const apiKeyInitial = {
contact: 'ApiKey',
name: 'ApiKey',
created: 1702830516,
key_id: 'F4lfa.fdas',
key_id: 'F4lfa.test',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this key id to be gibberish if it can be a word, cspell was getting mad at this test key everywhere

site_id: 1,
disabled: false,
roles: [
Expand Down Expand Up @@ -57,7 +57,7 @@ export const MultipleRoles = () => {
);
};

export const KeyWithRolesParticipantIsntAllowed = () => {
export const KeyWithRolesParticipantIsNotAllowed = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didnt like isnt without an apostrophe

const [isOpen, setIsOpen] = useState<boolean>(false);
const [apiKey, setApiKey] = useState<ApiKeyDTO>(apiKeyInitial);

Expand Down
2 changes: 1 addition & 1 deletion src/web/components/ApiKeyManagement/keyCreationDialog.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('Key creation dialog', () => {

await enterApiName('key_name');

apiRoles.map(async (apiRole) => {
apiRoles.forEach(async (apiRole) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonarlint suggestion

await clickApiRole(apiRole);
});

Expand Down
10 changes: 5 additions & 5 deletions src/web/components/ApiKeyManagement/keyEditDialog.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function loadComponent(apiKeyRoles: ApiRoleDTO[], participantApiRoles: ApiRoleDT
contact: 'ApiKey',
name: 'ApiKey',
created: 1702830516,
key_id: 'F4lfa.fdas',
key_id: 'F4lfa.test',
site_id: 1,
disabled: false,
roles: apiKeyRoles,
Expand Down Expand Up @@ -99,7 +99,7 @@ describe('Key edit dialog', () => {

expect(onEditMock).toHaveBeenCalledWith(
{
keyId: 'F4lfa.fdas',
keyId: 'F4lfa.test',
newName: 'ApiKey',
newApiRoles: apiKeyRoles.map((role) => role.roleName),
},
Expand All @@ -119,7 +119,7 @@ describe('Key edit dialog', () => {

expect(onEditMock).toHaveBeenLastCalledWith(
{
keyId: 'F4lfa.fdas',
keyId: 'F4lfa.test',
newName: 'ApiKey Rename',
newApiRoles: ['MAPPER'],
},
Expand Down Expand Up @@ -156,7 +156,7 @@ describe('Key edit dialog', () => {

expect(onEditMock).toHaveBeenCalledWith(
{
keyId: 'F4lfa.fdas',
keyId: 'F4lfa.test',
newName: 'ApiKey',
newApiRoles: [...apiKeyRoles, Bidder].map((role) => role.roleName),
},
Expand Down Expand Up @@ -187,7 +187,7 @@ describe('Key edit dialog', () => {

expect(onEditMock).toHaveBeenCalledWith(
{
keyId: 'F4lfa.fdas',
keyId: 'F4lfa.test',
newName: 'ApiKey',
newApiRoles: apiKeyRoles.filter((role) => role !== Mapper).map((role) => role.roleName),
},
Expand Down
6 changes: 3 additions & 3 deletions src/web/components/ParticipantManagement/ParticipantManagementItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@ import EditParticipantDialog from './EditParticipantDialog';

import './ParticipantManagementItem.scss';

type ParticipantManagmentItemProps = Readonly<{
type ParticipantManagementItemProps = Readonly<{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management misspelling was causing a lot of errors

participant: ParticipantDTO;
apiRoles: ApiRoleDTO[];
participantTypes: ParticipantTypeDTO[];
onUpdateParticipant: (form: UpdateParticipantForm, participant: ParticipantDTO) => Promise<void>;
}>;

export function ParticipantManagmentItem({
export function ParticipantManagementItem({
participant,
apiRoles,
participantTypes,
onUpdateParticipant,
}: ParticipantManagmentItemProps) {
}: ParticipantManagementItemProps) {
const [showEditParticipantDialog, setShowEditParticipantDialog] = useState<boolean>(false);

const onOpenChangeEditParticipantDialog = () => {
Expand Down
4 changes: 2 additions & 2 deletions src/web/components/ParticipantManagement/ParticipantManagementTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { PagingTool } from '../Core/Paging/PagingTool';
import { RowsPerPageValues } from '../Core/Paging/PagingToolHelper';
import { SortableTableHeader } from '../Core/Tables/SortableTableHeader';
import { TableNoDataPlaceholder } from '../Core/Tables/TableNoDataPlaceholder';
import { ParticipantManagmentItem } from './ParticipantManagementItem';
import { ParticipantManagementItem } from './ParticipantManagementItem';

import './ParticipantManagementTable.scss';

Expand Down Expand Up @@ -116,7 +116,7 @@ function ParticipantManagementTableContent({

<tbody>
{pagedRows.map((participant) => (
<ParticipantManagmentItem
<ParticipantManagementItem
key={participant.id}
participant={participant}
participantTypes={participantTypes}
Expand Down
Loading