Merge pull request #98 from IABTechLab/llp-UID2-3970-fix-type-errors

Add type information for well-known window properties.

Author: lionell-pack-ttd

src/euidSdk.ts

@@ -1,6 +1,7 @@
 import { EventType, CallbackHandler } from './callbackManager';
 import { CallbackContainer, sdkAssertErrorText, SdkBase, SDKSetup } from './sdkBase';
 import { ProductDetails } from './product';
+import { UidSecureSignalProviderType } from './secureSignal_types';
 
 export * from './exports';
 
@@ -51,6 +52,7 @@ export class EUID extends SdkBase {
 declare global {
   interface Window {
     __euid: EUID | SDKSetup | undefined;
+    __euidSecureSignalProvider?: UidSecureSignalProviderType;
   }
 }
 export function assertEUID(sdk: typeof window.__euid): asserts sdk is EUID {

src/secureSignalEuid.ts

@@ -1,11 +1,12 @@
 import { isDebugModeOn, UidSecureSignalProvider } from './secureSignal_shared';
+import { UidSecureSignalProviderType } from './secureSignal_types';
 
 const INTEG_BASE_URL = 'https://cdn.integ.euid.eu/';
 
 declare global {
   interface Window {
     getEuidAdvertisingToken?: () => Promise<string | null | undefined>;
-    __euidSecureSignalProvider?: UidSecureSignalProvider;
+    __euidSecureSignalProvider?: UidSecureSignalProviderType;
   }
 }
 

src/secureSignalUid2.ts

@@ -1,11 +1,12 @@
 import { isDebugModeOn, UidSecureSignalProvider } from './secureSignal_shared';
+import { UidSecureSignalProviderType } from './secureSignal_types';
 
 const INTEG_BASE_URL = 'https://cdn.integ.uidapi.com/';
 
 declare global {
   interface Window {
     getUid2AdvertisingToken?: () => Promise<string | null | undefined>;
-    __uid2SecureSignalProvider?: UidSecureSignalProvider;
+    __uid2SecureSignalProvider?: UidSecureSignalProviderType;
   }
 }
 

src/secureSignal_shared.ts

@@ -1,5 +1,7 @@
+import { UidSecureSignalProviderType } from './secureSignal_types';
+
 const MAXIMUM_RETRY = 3;
-export class UidSecureSignalProvider {
+export class UidSecureSignalProvider implements UidSecureSignalProviderType {
   debug: boolean;
   isEuid: boolean;
 
@@ -73,9 +75,7 @@ export class UidSecureSignalProvider {
 
       async function attempt(error?: unknown) {
         if (attempts >= retries) {
-          window.__uid2SecureSignalProvider?.logging(
-            `getUidAdvertisingTokenWithRetry failed with error after retry: ${error}`
-          );
+          that.logging(`getUidAdvertisingTokenWithRetry failed with error after retry: ${error}`);
 
           reject(error);
           return;

src/secureSignal_types.ts

@@ -0,0 +1,3 @@
+export interface UidSecureSignalProviderType {
+  registerSecureSignalProvider: () => void;
+}

src/uid2Sdk.ts

@@ -8,6 +8,7 @@ import { isBase64Hash } from './hashedDii';
 import { hashAndEncodeIdentifier, hashIdentifier } from './encoding/hash';
 import { CallbackContainer, sdkAssertErrorText, SdkBase, SDKSetup } from './sdkBase';
 import { ProductDetails } from './product';
+import { UidSecureSignalProviderType } from './secureSignal_types';
 
 export * from './exports';
 
@@ -100,6 +101,7 @@ declare global {
   interface Window {
     __uid2: UID2 | SDKSetup | undefined;
     __uid2Helper: UID2Helper | undefined;
+    __uid2SecureSignalProvider?: UidSecureSignalProviderType;
   }
 }