More changes to make the base SDK class reusable for EUID. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in default base URL, cookie name, and local storage key name to relevant classes and make internal values harder to access externally. Remove unused (and out of date) Prebid.js module file. Mark isLoginRequired as deprecated and provide a new alternative (less misleading) name. Move setIdentityFromPhone (and hash version) to the UID2 class, as it's only available on UID2.
lionell-pack-ttd
commented
Feb 9, 2024
lionell-pack-ttd
commented
Feb 9, 2024
lionell-pack-ttd
commented
Feb 9, 2024
lionell-pack-ttd
commented
Feb 9, 2024
alex-yau-ttd
approved these changes
Feb 12, 2024
Use JSDoc format for the deprecated function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move hashing and base64 encoding out to a separate module.
Pass in default base URL, cookie name, and local storage key name to relevant classes and make internal values harder to access externally.
Remove unused (and out of date) Prebid.js module file.
Mark isLoginRequired as deprecated and provide a new alternative (less misleading) name.
Move setIdentityFromPhone (and hash version) to the UID2 class, as it's only available on UID2.