Enable EUID in the SDK #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add relevant EUID tests (mostly we'll rely on the UID2 tests). Make the callback manager handle SDKLoaded state separately for each SDK.
src/uid2CallbackManager.ts
Outdated
| this._logger = logger; | ||
| this._getIdentity = getIdentity; | ||
| this._sdk = sdk; | ||
| this._sdk.callbacks.push = this.callbackPushInterceptor.bind(this); | ||
| } | ||
|
|
||
| private static _sentSdkLoaded = false; //TODO: This needs to be fixed for EUID! | ||
| private static _sentSdkLoaded: Record<string, boolean> = {}; //TODO: This needs to be fixed for EUID! |
There was a problem hiding this comment.
Does this comment still apply?
There was a problem hiding this comment.
Good catch - no, this fixes it for EUID :) I'll update it.
examples/cstg/html/index.html
Outdated
| </script> | ||
| </head> | ||
| <body> | ||
| <h1>Server-Side Integration Example, UID2 JavaScript SDK</h1> | ||
| <h1>CSTG Integration Example, UID2 JavaScript SDK</h1> |
There was a problem hiding this comment.
Is it worth adding "EUID" to the title here? Or even removing "UID2" since it is specified in the table below?
There was a problem hiding this comment.
I'll update.
ssundahlTTD
reviewed
Feb 14, 2024
Removed the base SDK class to a separate file. Minor tweaks.
…euid # Conflicts: # examples/cstg/html/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.