Setup JS SDK for distribution to EUID CDN #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Configure webpack to also build euid-sdk - Add steps to github action for EUID - Not in code: I have also added vars.EUID_S3_BUCKET and secrets.EUID_AWS_DISTRIBUTION_ID for integ in Github
alex-yau-ttd
changed the title
alex-yau-ttd
commented
Mar 15, 2024
| @@ -18,10 +19,14 @@ module.exports = (env, argv) => { | |||
| devtool: prodSourceMaps ? 'source-map' : false, | |||
| entry: !env.espOnly | |||
| ? { | |||
| main: { | |||
There was a problem hiding this comment.
main is used for single entry point, docs: https://webpack.js.org/concepts/entry-points/
Out of code: populate AWS_ACCOUNT_ID and EUID_AWS_ACCOUNT_ID variables in github
| environment: ${{ matrix.environment }} | ||
| artifact: euidSDK-${{ (matrix.environment == 'integ' && 'development') || matrix.environment }}-${{ needs.build.outputs.sdkVersion}} | ||
| invalidate_paths: '/euid-sdk-${{ needs.build.outputs.sdkVersion}}.js' | ||
| aws_account_id: ${{ vars.EUID_AWS_ACCOUNT_ID }} |
There was a problem hiding this comment.
Have you added the new vars and secret?
lionell-pack-ttd
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Successful run at: https://github.com/IABTechLab/uid2-web-integrations/actions/runs/8322196943, where the integ sdk can be seen at https://cdn.integ.euid.eu/euid-sdk-3.3.0.js.
Not in code
I have also added the following Github variables for integ & prod:
And secrets: