Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update energy service variables & Add Useful Energy #275

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jkikstra
Copy link
Contributor

For ScenarioMIP analysis, per discussion in #270 and also discussion with @vruijven @christophbertram @gunnar-pik @volker-krey

@jkikstra
Copy link
Contributor Author

Not sure what exactly is causing the 'illegal character' error:

=========================== short test summary info ============================
FAILED tests/test_legacy.py::test_legacy_variables - ValueError: Collected 2 errors:
  1. Unexpected character in variable: 'Production|Iron and Steel'. Check for illegal characters and/or if tags were spelled correctly.
  2. Unexpected character in variable: 'Production|Non-Metallic Minerals'. Check for illegal characters and/or if tags were spelled correctly.
FAILED tests/test_reserved_terms.py::test_variable_ops_as_square_brackets - ValueError: Collected 2 errors:
  1. Unexpected character in variable: 'Production|Iron and Steel'. Check for illegal characters and/or if tags were spelled correctly.
  2. Unexpected character in variable: 'Production|Non-Metallic Minerals'. Check for illegal characters and/or if tags were spelled correctly.
========================= 2 failed, 1 warning in 6.05s =========================

unit: Mt/yr
tier: 1
components:
- Production|Iron and Steel|{Iron Commodity}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replacement doesn't work (if the tag isn't used in the variable name), hence the illegal-character error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so if I want to add a top-level variable like this & add the list of components, would there be another way, or would I always have to list them all, or just not list the components?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advise against listing components if these are all sub-categories. This is more confusing than helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants