You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've noticed a change in table output formatting after upgrading the SDK. Specifically, table headers are no longer rendered in bold, which seems to conflict with the IBM Cloud CLI plugin developer guide.
What's Happening
In PrintableTable.Print(), a go-pretty table writer is created and configured, but header styling is not explicitly set:
* Was bold header styling previously expected, or was it incidental due to changes in `go-pretty`?
Yes, it was incidental due to the change to using go-pretty
* Would the team be open to explicitly restoring header styling as part of the SDK?
Yes
* Would you accept a PR for this fix? (When I tested this fix on a branch, tests failed as they were [not expecting bold headers](https://github.com/IBM-Cloud/ibm-cloud-cli-sdk/blob/master/bluemix/terminal/table_test.go#L22))
Yes. That is a good catch. We have not been testing bold in the headers.
Thanks for maintaining the SDK! Happy to help further if needed.
Hi team,
We've noticed a change in table output formatting after upgrading the SDK. Specifically, table headers are no longer rendered in bold, which seems to conflict with the IBM Cloud CLI plugin developer guide.
What's Happening
In
PrintableTable.Print()
, ago-pretty
table writer is created and configured, but header styling is not explicitly set:Version History
We observed this behaviour when upgrading from:
github.com/IBM-Cloud/ibm-cloud-cli-sdk v1.5.0
to
v1.6.2
(which introducedgo-pretty/v6 v6.6.1
)We also tried updating to
v1.7.1
, and the behaviour remains unchanged - headers still render as plain text.Developer Guide Inconsistency
According to the IBM Cloud CLI Plugin Developer Guide (Section 2.11):
This suggests that bold headers are still part of the intended user experience.
Proposed Fix
To align with the documented guidance and preserve visual consistency across CLI plugins, consider adding this line to
PrintableTable.Print()
:This would restore bold headers and ensure compatibility with future
go-pretty
updates.Questions
go-pretty
?Thanks for maintaining the SDK! Happy to help further if needed.
The text was updated successfully, but these errors were encountered: