Skip to content

fix(atracker) do not return region if it is not defined for resource #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

wenjian2
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

Test 1:

$ make testacc TEST=./ibm/service/atracker TESTARGS='-run=TestAccIBMAtracker*'
=== RUN   TestAccIBMAtrackerRoutesDataSourceBasic
--- PASS: TestAccIBMAtrackerRoutesDataSourceBasic (16.00s)
=== RUN   TestAccIBMAtrackerTargetsDataSourceBasic
--- PASS: TestAccIBMAtrackerTargetsDataSourceBasic (12.91s)
=== RUN   TestAccIBMAtrackerTargetsDataSourceAllArgs
--- PASS: TestAccIBMAtrackerTargetsDataSourceAllArgs (13.19s)
=== RUN   TestAccIBMAtrackerRouteBasic
--- PASS: TestAccIBMAtrackerRouteBasic (24.16s)
=== RUN   TestAccIBMAtrackerRouteBasicMultipleRules
--- PASS: TestAccIBMAtrackerRouteBasicMultipleRules (24.18s)
=== RUN   TestAccIBMAtrackerSettingsBasic
--- PASS: TestAccIBMAtrackerSettingsBasic (12.96s)
=== RUN   TestAccIBMAtrackerSettingsAllArgs
--- PASS: TestAccIBMAtrackerSettingsAllArgs (14.15s)
=== RUN   TestAccIBMAtrackerTargetBasic
--- PASS: TestAccIBMAtrackerTargetBasic (20.94s)
=== RUN   TestAccIBMAtrackerTargetAllArgs
--- PASS: TestAccIBMAtrackerTargetAllArgs (23.56s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/atracker        163.643s

Test 2:

$ TF_ACC=1 go test ./ibm/service/atracker -timeout 700m -v
=== RUN   TestAccIBMAtrackerRoutesDataSourceBasic
--- PASS: TestAccIBMAtrackerRoutesDataSourceBasic (13.88s)
=== RUN   TestDataSourceIBMAtrackerRoutesRouteToMap
--- PASS: TestDataSourceIBMAtrackerRoutesRouteToMap (0.00s)
=== RUN   TestDataSourceIBMAtrackerRoutesRuleToMap
--- PASS: TestDataSourceIBMAtrackerRoutesRuleToMap (0.00s)
=== RUN   TestAccIBMAtrackerTargetsDataSourceBasic
--- PASS: TestAccIBMAtrackerTargetsDataSourceBasic (12.30s)
=== RUN   TestAccIBMAtrackerTargetsDataSourceAllArgs
--- PASS: TestAccIBMAtrackerTargetsDataSourceAllArgs (12.67s)
=== RUN   TestAccIBMAtrackerRouteBasic
--- PASS: TestAccIBMAtrackerRouteBasic (23.55s)
=== RUN   TestAccIBMAtrackerRouteBasicMultipleRules
--- PASS: TestAccIBMAtrackerRouteBasicMultipleRules (25.02s)
=== RUN   TestResourceIBMAtrackerRouteRuleToMap
--- PASS: TestResourceIBMAtrackerRouteRuleToMap (0.00s)
=== RUN   TestResourceIBMAtrackerRouteMapToRulePrototype
--- PASS: TestResourceIBMAtrackerRouteMapToRulePrototype (0.00s)
=== RUN   TestAccIBMAtrackerSettingsBasic
--- PASS: TestAccIBMAtrackerSettingsBasic (11.96s)
=== RUN   TestAccIBMAtrackerSettingsAllArgs
--- PASS: TestAccIBMAtrackerSettingsAllArgs (15.24s)
=== RUN   TestAccIBMAtrackerTargetBasic
--- PASS: TestAccIBMAtrackerTargetBasic (20.55s)
=== RUN   TestAccIBMAtrackerTargetAllArgs
--- PASS: TestAccIBMAtrackerTargetAllArgs (22.41s)
=== RUN   TestResourceIBMAtrackerTargetCosEndpointToMap
--- PASS: TestResourceIBMAtrackerTargetCosEndpointToMap (0.00s)
=== RUN   TestResourceIBMAtrackerTargetEventstreamsEndpointToMap
--- PASS: TestResourceIBMAtrackerTargetEventstreamsEndpointToMap (0.00s)
=== RUN   TestResourceIBMAtrackerTargetCloudLogsEndpointToMap
--- PASS: TestResourceIBMAtrackerTargetCloudLogsEndpointToMap (0.00s)
=== RUN   TestResourceIBMAtrackerTargetWriteStatusToMap
--- PASS: TestResourceIBMAtrackerTargetWriteStatusToMap (0.00s)
=== RUN   TestResourceIBMAtrackerTargetMapToCosEndpointPrototype
--- PASS: TestResourceIBMAtrackerTargetMapToCosEndpointPrototype (0.00s)
=== RUN   TestResourceIBMAtrackerTargetMapToEventstreamsEndpointPrototype
--- PASS: TestResourceIBMAtrackerTargetMapToEventstreamsEndpointPrototype (0.00s)
=== RUN   TestResourceIBMAtrackerTargetMapToCloudLogsEndpointPrototype
--- PASS: TestResourceIBMAtrackerTargetMapToCloudLogsEndpointPrototype (0.00s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/atracker        159.069s

@wenjian2
Copy link
Contributor Author

Fix issue #6191

@hkantare hkantare merged commit 5995c04 into IBM-Cloud:master Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants