-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin RefinedRust to a specific version #70
Conversation
Signed-off-by: Lennard Gäher <l.gaeher@posteo.de>
77c30b7
to
e607b6d
Compare
Thank you for the PR. I am fine with pinning RefinedRust. However, the current |
Yeah, that makes sense. I'm not sure the changes in this PR are the root cause for the failure though. After this run failed, I re-ran the build pipeline on current main, and it fails with the same message: https://github.com/IBM/ACE-RISCV/actions/runs/10014257449/job/28567659391 I'm not sure what may have caused this, since the same job ran fine a couple of weeks ago. |
Right, probably Github actions reduces disk space for the pipeline jobs. We can then decrease the test VM image size. Let me try it out. |
…m size Signed-off-by: Wojciech Ozga <woz@zurich.ibm.com>
Seems like this is a problem others are experiencing as well: actions/runner-images#10386 Some people report that switching to ubuntu-24.04 works. Or we could wait until this is fixed. |
Signed-off-by: Wojciech Ozga <woz@zurich.ibm.com>
Signed-off-by: Wojciech Ozga <woz@zurich.ibm.com>
I have changed CI base image to Ubuntu-24.04 and, indeed, it works fine. Looks like we can merge this PR now. |
Thanks! |
Description of the changes
Currently, we do not fix a particular RefinedRust version. Since RefinedRust has regular breaking changes, fixing a particular version and only updating it together with new verification results/when the need arises will reduce the maintenance burden.
For this, I included RefinedRust as a submodule, as this is how we pin existing dependencies as well.
Type of change
How to test this PR?
It's sufficient to check whether CI passes.