Skip to content

Commit 9360f0f

Browse files
Add exports for standalone test environment (#363)
Issue #225 migrated OpenJCEPlus and associated tests to use the sun.security.util.Debug class. Two export statements were not included for cases where the tests are being executed in a standalone test environment where the provider is already bundled with the SDK. Signed-off-by: Jason Katonica <katonica@us.ibm.com>
1 parent 945cc08 commit 9360f0f

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

pom.xml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,14 +374,17 @@
374374
<arg>java.base/jdk.internal.logger=openjceplus</arg>
375375
<!--
376376
Exports statements below this line are necessary for
377-
compiling only the test source with target `test-compile`.
377+
compiling the test source with target `test-compile`.
378378
When compiling only the tests, using an SDK that contains
379-
a bundled version of OpenJCEPlus, the package
380-
com.ibm.crypto.plus.provider.ock must be explictly exported
381-
for unit testing purposes for the tests to compile.
379+
a bundled version of OpenJCEPlus, some packages must
380+
still be explicitly exported for compilation to pass.
382381
-->
383382
<arg>--add-exports </arg>
384383
<arg>openjceplus/com.ibm.crypto.plus.provider.ock=ALL-UNNAMED</arg>
384+
<arg>--add-exports </arg>
385+
<arg>java.base/sun.util.logging=ALL-UNNAMED</arg>
386+
<arg>--add-exports </arg>
387+
<arg>java.base/jdk.internal.logger=ALL-UNNAMED</arg>
385388
</compilerArgs>
386389
<fork>true</fork>
387390
<debug>true</debug>

0 commit comments

Comments
 (0)