Skip to content

Revisit aria_landmark_name_unique rule logic for "regions" duplications #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philljenkins opened this issue Feb 4, 2025 · 2 comments
Assignees
Labels
Bug Something isn't working Carbon Carbon related issue engine Issues in the accessibility-checker-engine component T70 user-reported Issues identified outside of the core team

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Feb 4, 2025

Originally reported by @David-Yuen

Related to #2157 that was previously closed for "Search" cases.

Triggered by
Rule ID: aria_region_label_unique
Reason ID: Fail_1
Violation
Multiple elements with "region" role do not have unique labels
Each element with "region" role must have a unique label that describes its purpose

reproduce via

  1. Test page: https://githubuobskza7-51hx--5173--d20a0a75.local-credentialless.webcontainer.io/
  2. Clicked the "Maximize" button on the top right, this opens a Tearsheet modal window with the same instance of the Table.
  3. Scan page, the rule above throws incorrect non-unique label error

Image

@philljenkins philljenkins added user-reported Issues identified outside of the core team engine Issues in the accessibility-checker-engine component labels Feb 4, 2025
@philljenkins
Copy link
Contributor Author

Before fix in #2157, there were two region label errors incorrectly triggered, both a "search" and a "region":

Image

After fix, only one region label is incorrectly triggered, a "region" label.

  • Hint: may this be due to the use of the "rare" <section... element?

Image

@shunguoy
Copy link
Contributor

shunguoy commented Feb 17, 2025

triage: 1. nested landmarks; 2. need an SME discussion for a consensus on handling this: should names for all the landmarks be unique? https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/region.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Carbon Carbon related issue engine Issues in the accessibility-checker-engine component T70 user-reported Issues identified outside of the core team
Projects
None yet
Development

No branches or pull requests

2 participants