Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating shackle functionality in Achaea #113

Open
antar5 opened this issue Jul 12, 2019 · 4 comments
Open

Updating shackle functionality in Achaea #113

antar5 opened this issue Jul 12, 2019 · 4 comments

Comments

@antar5
Copy link

antar5 commented Jul 12, 2019

Probably a relic from when mass used to do damage on movement, but shackle use by mapper can be made more efficient.

Changes that can be made:

  • No longer remove shackle on normal speedwalking when the config option for shackle is enabled. Mass has no impact on normal speedwalking, so its unnecessary.

-With shackle option enabled, remove shackle only when the dash argument and its sister equivalents are included. Can do this two ways - easier to just remove shackle at the start of speedwalking and wear it once completed, like it currently does. Or can remove the shackle before each individual dash and wear it after the dash is completed, which is all that is necessary.

@QwindorRousseau
Copy link
Contributor

I had decided when I made the function and the option was just to have it unwear at start and wear at end just to keep down on the spam and commands being sent.

@antar5
Copy link
Author

antar5 commented Jul 12, 2019

Yeah, I figured that'd be the case. That only eliminates removing shackle on individual dashes, it should still be changed to only remove shackle if the dash or equivalent arguments are including in speedwalking. There are no downsides to this as far as I know (beneficial, really, since you ideally don't want shackle off for no reason).

@QwindorRousseau
Copy link
Contributor

Did they ninja change that running around while massed didn't start to hurt your health after moving for a ton of rooms then? I know i still get the out of breath message when i follow someone who does that and I don't remove shackle but I haven't paid attention to the health amount.

@antar5
Copy link
Author

antar5 commented Jul 12, 2019

Yeah, you no longer take damage from moving while massed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants