-
Notifications
You must be signed in to change notification settings - Fork 3
Pyright and ruff checking for Database Server #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyright and ruff checking for Database Server #399
Conversation
Unfortunately looks like unit tests are broken by this:
You may need to guard some imports with |
def _is_list_of_str_list(val: list[list]) -> TypeGuard[list[list[str]]]: | ||
sublist_vals = [_is_list_of_str(sublist) for sublist in val] | ||
return all(sublist_vals) | ||
|
||
|
||
def _is_list_of_str(val: list) -> TypeGuard[list[str]]: | ||
return all(isinstance(val, str) for x in val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…ub.com/ISISComputingGroup/EPICS-inst_servers into Ticket8527_Database_server_Type_checking
should be fixed now I think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins unhappiness should be solved by your g_p PR.
Description of work
Performed ruff and pyright checks on the database server
To test
Which ticket does this PR fix?
Relies on:
https://github.com/ISISComputingGroup/genie_python/pull/442