Prepare for and hold a pyright/Ruff correction day (suggested date 17th October 2024)

[KathrynBaker]

As a developer working on IBEX I want to clear out and correct the legacy pyright/ruff errors that are in the system now that we have instigated these checks as standard so that small/urgent changes don't lead to lots of fixing.

Acceptance Criteria

• Everyone who can spends as much time as they can on this day fixing these issues
• The named person on this ticket provides a breakdown of the work needed to facilitate the team undertaking the task (this has to be done before the day is held)

Notes

• The majoirty of the group are available for the whole of that day, making it a suitable choice for this kind of focussed day

[Tom-Willemsen]

To maximise the benefit of this day, I think we should focus on core/central pieces of code rather than beamline or device-specific stuff. Also try to target repos with higher churn as fixing issues in those repos will have biggest benefit.

Initial repos to target (we likely won't get through all of these):

• Block server
  • This can likely be split between multiple people
• Genie_python
  • Some bits already done, remaining bits can be split between multiple people
    • MySql Abstraction Layer started @LowriJenkins
    • ready for review. (PR)
    • Under review @Tom-Willemsen
    • done
• System tests
  • This can likely be split between multiple people
• Upgrade scripts
  • started @Chsudeepta
  • Ready of review ==> PR
  • Under revoew @LowriJenkins
  • done
• Install scripts
• Database server
  • started @LowriJenkins
  • ready for review (PR)
  • Under review @Tom-Willemsen
  • done
• Reflectometry server
• IOC test framework central utilities
  • started @Tom-Willemsen
  • ready for review (PR: Ruff/pyright EPICS-IOC_Test_Framework#645)
  • under review @LowriJenkins
  • done
• Device emulator central utilities started @jackbdoughty
  • EPICS-DeviceEmulator - PR
  • (front facing) lewis - did 3 files that are used often PR
• Configchecker started @davidkeymer
• Device generator
  • Started @LilithCole
  • Ready for review PR
  • Under review
  • Done
• Top level EPICS scripts e.g. check_scripts (repo checks), build_ioc_startups

[GRyall]

I suggest also checking that the device generator generates devices that are compliant (my device from the old generator is not, apologies if this has already been done)

[LowriJenkins]

Some of the genie python files will be done by https://github.com/ISISComputingGroup/genie_python/pull/439/files as well

[davidkeymer]

Some changes in the Config Checker repository: PR

[LowriJenkins]

DatabaseServer
Required Genie Python File

[LowriJenkins]

Do we want to propose a follow up to this ticket to deal with the area's not dealt with during this one? i.e. Blockserver, system tests, reflectometry server, and top level epics scripts?

[GRyall]

Follow on ticket: #8553

[GRyall]

Remaining PRs to complete reviews for before this issue can be closed:

• Ticket8527 ruff pyright IBEX-device-generator#4
• Ticket 8527 fix ruff pyright EPICS-upgrade#83

All others have been reviewed and merged.

[Chsudeepta]

There are a number of repos which haven't been touched. Also for upgrade, when I created the PR, I wasn't aware that the ruleset I was using and the one builds are using aren't same. So I am doing more change to Upgrade (So the PR is really not ready).

[GRyall]

There are a number of repos which haven't been touched.

Yes - that is why there is a follow on ticket. I think this ticket can be considered complete when the work done for the day has been reviewed and merged.

So the PR is really not ready

Understood - my comment was a holding one so it is clear at a glance why the ticket is still in review, not a chase.

[Chsudeepta]

The PR for the upgrade module is now available for review --> PR_UPGRADE

[LowriJenkins]

Are the remaining PR's here still under review? or is this a case of people all thinking someone else is looking into this?

[GRyall]

The device generator one has outstanding comments. I briefly looked at the epics-upgrade one, but am not actively reviewing it.

[LowriJenkins]

I'll have a look at the epics upgrade one then

[LowriJenkins]

Just device generator left to do

[GRyall]

completion of ISISComputingGroup/IBEX-device-generator#4 has been moved into #8553. All other PRs have been reviewed, so closing this ticket.