Prepare for and hold a second pyright/Ruff correction day [21st May]

[GRyall]

Issue Description

As a developer working on IBEX I want to continue to clear out and correct the legacy pyright/ruff errors that are in the system now that we have instigated these checks as standard so that small/urgent changes don't lead to lots of fixing. This will follow on and add to the work started in #8527.

Acceptance Criteria

_{What is the acceptance criteria of this ticket? What should the reviewer expect to be complete?}

• Identify a day that the majority of the group are free and available and book it in the calendars
• Everyone who can spends as much time as they can on this day fixing these issues
• Open tasks from previous pyright ticket are continued
• The named person on this ticket provides a breakdown of the work needed (including carried over) to facilitate the team undertaking the task (this has to be done before the day is held). Prepare for and hold a pyright/Ruff correction day (suggested date 17th October 2024) #8527 can be used as a starting point. The breakdown should make it possible to see at a glance who is working on what and to track PRs and completion of work.
• If required, a follow up ticket for remaining work is created

How to Review

_{Before making a PR...}

• Provide verbose instructions for the reviewer to test that your changes work and fix the issue
• Describe if/how you have implemented testing for this issue
• Provide screenshots of the feature to help the reviewer if relevant

planning 69:00 2024/10/31

Time in recording of planning meeting: 00h12m 2024/11/28
Discussed planning 05/02/2025 00:30:30

[LowriJenkins]

Might be good to briefly discuss at planning whether this needs to be another whole day, or we whether what remains isn't large enough to justify a full tech-debt style day.

[Tom-Willemsen]

Friday is more important for this sprint, defer this to maybe January

[LowriJenkins]

ISISComputingGroup/IBEX-device-generator#4 Open PR from previous pyright day

[jackbdoughty]

What still needs doing. I am suggesting we make genie_python our main focus for the day with the rest of the core python repos that need doing at the bottom to be carried over.

• device generator (needs reviewing Ticket8527 ruff pyright IBEX-device-generator#4)

genie_python

• block_names.py (Ruff: ❌, Pyright: ❌)

  • Started @jackbdoughty
  • Ready for Review pr
  • Under Review
  • Done

• channel_access_exceptions.py (Ruff: ❌, Pyright: ❌)

  • Started @iangillingham-stfc
  • Ready for Review
  • Under Review
  • Done

• genie.py (Ruff: ✅, Pyright: ❌)

  • Started @jackbdoughty
  • Ready for Review PR (effects other files)
  • Under Review
  • Done

• genie_advanced.py (Ruff: ✅, Pyright: ❌)

  • Started by @LilithCole
  • Ready for Review pyright fixes for genie_advanced genie#44
  • Under Review
  • Done

• genie_alerts.py (Ruff: ❌, Pyright: ❌)

  • Started @iangillingham-stfc
  • Ready for Review Ruff and pyright ig genie#41
  • Under Review
  • Done

• genie_api_setup.py (Ruff: ✅, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_blockserver.py (Ruff: ❌, Pyright: ❌)

  • Started @LowriJenkins
  • Ready for Review
  • Under Review
  • Done

• genie_cachannel_wrapper.py (Ruff: ✅, Pyright: ❌)

  • Started @LowriJenkins
  • Ready for Review Ticket8553 pyright day ca channel wrapper genie#36
  • Under Review
  • Done

• genie_change_cache.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_dae.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_epics_api.py (Ruff: ✅, Pyright: ❌)

  • Started @LowriJenkins
  • Ready for Review Fix pyright and ruff for genie_epics_api genie#46
  • Under Review
  • Done

• genie_experimental_data.py (Ruff: ✅, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_logging.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_plot.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_pre_post_cmd_manager.py (Ruff: ❌, Pyright: ❌)

  • Started by @LilithCole
  • Ready for Review pyright fixes for genie_advanced genie#44
  • Under Review
  • Done

• genie_script_checker.py (Ruff: ✅, Pyright: ❌)

  • Started by @LilithCole
  • Ready for Review pyright errors genie#37
  • Under Review
  • Done

• genie_script_generator.py (Ruff: ✅, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_simulate.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_simulate_impl.py (Ruff: ✅, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_startup.py (Ruff: ✅, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_toggle_settings.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_waitfor.py (Ruff: ❌, Pyright: ❌)

  • Started
  • Ready for Review
  • Under Review
  • Done

• genie_wait_for_move.py (Ruff: ❌, Pyright: ❌)

  • Started @Tom-Willemsen
  • Ready for Review (PR)
  • Under Review
  • Done

• mysql_abstraction_layer.py (Ruff: ✅, Pyright: ❌)

  • Started @Tom-Willemsen
  • Ready for Review (PR)
  • Under Review
  • Done

• scanning_instrument_pylint_plugin.py (Ruff: ✅, Pyright: ❌)

  • Started @Tom-Willemsen
  • Ready for Review (PR)
  • Under Review
  • Done

• utilities.py (Ruff: ❌, Pyright: ❌)

  • Started @Tom-Willemsen
  • Ready for Review (PR)
  • Under Review
  • Done

• matplotlib_backend\ibex_websocket_backend.py (Ruff: ❌, Pyright: ❌)

  • Started @Tom-Willemsen
  • Ready for Review (PR)
  • Under Review
  • Done

After this is done, the following core python repos need doing.

• Block server
• install scripts
• system tests
• top level epics scripts (e.g check_scripts, build_ioc_startups)

[Tom-Willemsen]

comment to make project board checks happier