Default to None rather than empty string #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
To test
Fixes #24
Acceptance criteria
With DBSVR running:
g.begin()
should not change meas_id / sample_id / sample_subid / meas_typeg.begin(sample_id="toms_fave_sample")
should change sample id and then beginWithout DBSVR running:
g.begin()
should begin a run without errorg.begin(sample_id="toms_fave_sample")
should stall with CA errors as we've explicitly asked to change a parameter but DBSVR is unreachable so that can't be doneCode Review
Functional Tests