Skip to content

Add warning on begin if using test clock #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LowriJenkins
Copy link
Contributor

Description of work

Adds a warning to the begin() function if the scientists are using the test clock and are not in simulated DAE

To test

ISISComputingGroup/IBEX#8725

Acceptance criteria

  • When begining a run from a script if the dae is not simulated and the test clock is active, a warning is printed telling the user that the test clock is active and how to change there timing source.

Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

@LowriJenkins LowriJenkins force-pushed the Ticket8725_Add_Test_clock_warning branch from 4183a7d to e867038 Compare May 16, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants