Skip to content

Fix pyright and ruff for genie_epics_api #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2025

Conversation

LowriJenkins
Copy link
Contributor

Description of work

Also edited block_names.py slightly

To test

ISISComputingGroup/IBEX#8553

@jackbdoughty jackbdoughty force-pushed the Ticket8553_Fix_ruff_and_pyright_in_genie_epics_api branch from 5ca8264 to 7eece59 Compare May 23, 2025 12:21
@jackbdoughty jackbdoughty requested a review from Copilot May 23, 2025 13:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses pyright and ruff issues for the genie_epics_api by updating type hints and adding necessary assertions, and also updates the block_names type in block_names.py.

  • Updated type annotations for function parameters and return types in genie_epics_api.py
  • Added assertions and overload definitions for improved type safety
  • Changed the block_names parameter type and added a type assertion in block_names.py

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/genie_python/genie_epics_api.py Refined type annotations, added overloads, and inserted type assertions
src/genie_python/block_names.py Updated the block_names parameter type and introduced a type check

jackbdoughty and others added 3 commits May 23, 2025 14:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jackbdoughty jackbdoughty merged commit af27df0 into main May 23, 2025
14 of 15 checks passed
@jackbdoughty jackbdoughty deleted the Ticket8553_Fix_ruff_and_pyright_in_genie_epics_api branch May 23, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants