Fix pyright and ruff for genie_epics_api #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jackbdoughty
force-pushed
the
Ticket8553_Fix_ruff_and_pyright_in_genie_epics_api
branch
from
5ca8264 to
7eece59
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses pyright and ruff issues for the genie_epics_api by updating type hints and adding necessary assertions, and also updates the block_names type in block_names.py.
- Updated type annotations for function parameters and return types in genie_epics_api.py
- Added assertions and overload definitions for improved type safety
- Changed the block_names parameter type and added a type assertion in block_names.py
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/genie_python/genie_epics_api.py | Refined type annotations, added overloads, and inserted type assertions |
| src/genie_python/block_names.py | Updated the block_names parameter type and introduced a type check |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ttps://github.com/ISISComputingGroup/genie into Ticket8553_Fix_ruff_and_pyright_in_genie_epics_api
jackbdoughty
approved these changes
May 23, 2025
Tom-Willemsen
approved these changes
May 23, 2025
jackbdoughty
deleted the
Ticket8553_Fix_ruff_and_pyright_in_genie_epics_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Also edited
block_names.pyslightlyTo test
ISISComputingGroup/IBEX#8553