Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configured kubernetes database name in config.yml. #65

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dawnbreak
Copy link
Contributor

You can already set a database name for the kubernetes database in values.yaml, also use this database name in the generated config.yml file.

You can already set a database name for the kubernetes database in values.yaml,
also use this database name in the generated config.yml file.
Copy link

cla-bot bot commented Oct 16, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @dawnbreak

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 17, 2024
@lippserd
Copy link
Member

Hi @dawnbreak, Thank you very much for the contribution!

@lippserd lippserd merged commit 8f66518 into Icinga:main Nov 12, 2024
2 checks passed
@eifelmicha
Copy link

This change actually breaks the icingaweb2 chart here:

value: {{ .Values.global.databases.kubernetes.database | quote }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants