Skip to content

tests(progressBar): Fix tests for Circular and Linear Bars not clearing test bed. #15887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 20.0.x
Choose a base branch
from
Open

tests(progressBar): Fix tests for Circular and Linear Bars not clearing test bed. #15887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions projects/igniteui-angular/src/lib/progressbar/circularbar.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ describe('IgxCircularProgressBarComponent', () => {
circularBar = fixture.debugElement.nativeElement;
});

afterEach(() => {
// Remove elements manually from DOM, because CircularBar overrides the id the TestBed uses
fixture.elementRef.nativeElement.remove();
fixture.destroy();
});
Comment on lines +30 to +33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is few lines above in the beforeEach for the exact same reason:

// For test fixture destroy
progress.id = "root1";

Did that stop working? Because it's used in other component's tests too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a follow up to the PR adding it. Should it be removed? Did it never work?


it('should initialize with default attributes', () => {
expect(progress.cssClass).toBe('igx-circular-bar');
expect(progress.textVisibility).toBe(true);
Expand Down
6 changes: 6 additions & 0 deletions projects/igniteui-angular/src/lib/progressbar/linearbar.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ describe('IgxLinearProgressBarComponent', () => {
linearBar = fixture.debugElement.nativeElement;
});

afterEach(() => {
// Remove elements manually from DOM, because LinearBar overrides the id the TestBed uses
fixture.elementRef.nativeElement.remove();
fixture.destroy();
});

it('should initialize with default attributes', () => {
expect(progress.valueMin).toBe(0);
expect(progress.cssClass).toBe('igx-linear-bar');
Expand Down
Loading