Skip to content

fix(combo): prefix/suffix directives not working #15898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(combo): prefix/suffix directives not working #15898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c612465
fix(combo): prefix/suffix directives not working
SisIvanova Jun 4, 2025
1f85ebf
Merge branch 'master' into sivanova/fix-15774
SisIvanova Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/combo/combo.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<ng-content select="[igxLabel]"></ng-content>
</ng-container>
<ng-container ngProjectAs="igx-prefix">
<ng-content select="igx-prefix"></ng-content>
<ng-content select="igx-prefix,[igxPrefix]"></ng-content>
</ng-container>
<ng-container ngProjectAs="igx-hint, [igxHint]">
<ng-content select="igx-hint, [igxHint]"></ng-content>
Expand All @@ -15,7 +15,7 @@
[attr.aria-labelledby]="ariaLabelledBy || label?.id || placeholder"
(blur)="onBlur()" />
<ng-container ngProjectAs="igx-suffix">
<ng-content select="igx-suffix"></ng-content>
<ng-content select="igx-suffix,[igxSuffix]"></ng-content>
</ng-container>
@if (displayValue) {
<igx-suffix [attr.aria-label]="resourceStrings.igx_combo_clearItems_placeholder" class="igx-combo__clear-button"
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</ng-container>

<ng-container ngProjectAs="igx-prefix">
<ng-content select="igx-prefix"></ng-content>
<ng-content select="igx-prefix,[igxPrefix]"></ng-content>
</ng-container>

<ng-container ngProjectAs="igx-hint, [igxHint]">
Expand All @@ -21,7 +21,7 @@
(keyup)="handleKeyUp($event)" (keydown)="handleKeyDown($event)" (blur)="onBlur()" (paste)="handleInputChange($event)"/>

<ng-container ngProjectAs="igx-suffix">
<ng-content select="igx-suffix"></ng-content>
<ng-content select="igx-suffix,[igxSuffix]"></ng-content>
</ng-container>

@if (hasSelectedItem) {
Expand Down
2 changes: 2 additions & 0 deletions src/app/input-group-showcase/input-group-showcase.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ <h1 class="showcase__title">Angular</h1>
@if (getLabel()) {
<label igxLabel>{{ getLabel() }}</label>
}
<igx-icon igxPrefix [hidden]="hidePrefix()">favorite</igx-icon>
<igx-icon igxSuffix [hidden]="hideSuffix()">favorite</igx-icon>
<igx-hint>Select a unique falsy value</igx-hint>
</igx-combo>

Expand Down
Loading