Skip to content

fix(button): active-shadow property is not applied on button active state #15914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025

Conversation

adrianptrv
Copy link

@adrianptrv adrianptrv commented Jun 6, 2025

Closes #15770

The Material contained button was using the box-shadow from the hover variable for its active state, as shown in the issue. Similarly, the Material fab button was using the focused variable box-shadow for its active state.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@adrianptrv adrianptrv requested a review from simeonoff June 6, 2025 11:42
@adrianptrv adrianptrv added styling ❌ status: awaiting-test PRs awaiting manual verification button labels Jun 6, 2025
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 6, 2025
@ChronosSF ChronosSF changed the base branch from master to 20.0.x June 9, 2025 11:54
@simeonoff simeonoff merged commit ba9380d into 20.0.x Jun 11, 2025
2 checks passed
@simeonoff simeonoff deleted the apetrov/active-shadow-var branch June 11, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
button styling ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button]: $active-shadow theming function parameter does not work
3 participants