Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error builder to image (#8) #11

Merged
merged 1 commit into from
Oct 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions lib/presentation/screens/feed/feed_image_widget.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import 'package:devour/presentation/widgets/platform/platform_icon_button.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';
import 'package:lottie/lottie.dart';
import 'package:octo_image/octo_image.dart';

/// A widget to show image from network or cache with correct size
class FeedImage extends StatelessWidget {
/// Construct FeedImag
const FeedImage({
Key? key,
this.constraints,
required this.imageProvider,
this.onRefreshPressed,
}) : super(key: key);

final BoxConstraints? constraints;
final ImageProvider imageProvider;
/// Callback fired, when user taps on error builder, when image is failed to load
final VoidCallback? onRefreshPressed;

@override
Widget build(BuildContext context) {
return ConstrainedBox(
constraints: BoxConstraints(
minHeight: 200,
maxWidth: constraints?.maxWidth ?? double.infinity,
),
child: OctoImage(
// key: widget.key,
image: imageProvider,
fit: BoxFit.fitWidth,
progressIndicatorBuilder: (ctx, prgrs) => SizedBox(
height: 200,
child: Lottie.asset(
'lib/assets/animations/space_loader.json',
),
),
errorBuilder: (ctx, error, stack) => SizedBox(
height: 200,
child: Center(
child: PlatformIconButton(
icon: Icons.refresh,
onPressed: onRefreshPressed,
color: CupertinoColors.white,
size: 24,
text: 'failed to load 🤬',
),
),
),
),
);
}
}
34 changes: 18 additions & 16 deletions lib/presentation/screens/feed/feed_widget.dart
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import 'dart:math';
import 'dart:ui';

import 'package:cached_network_image/cached_network_image.dart';
import 'package:devour/application/feed/bloc/feed_bloc.dart';
import 'package:devour/injection.dart';
import 'package:devour/presentation/screens/feed/feed_image_widget.dart';
import 'package:devour/presentation/screens/feed/feed_scroll_physics.dart';
import 'package:devour/presentation/screens/feed/post_widget.dart';
import 'package:devour/presentation/widgets/animations/animated_opacity_reverse.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
Expand All @@ -14,7 +15,6 @@ import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
import 'package:fpdart/fpdart.dart' show Option;
import 'package:lottie/lottie.dart';
import 'package:octo_image/octo_image.dart';
import 'package:scrollable_positioned_list/scrollable_positioned_list.dart';
import 'package:collection/collection.dart';

Expand Down Expand Up @@ -111,7 +111,6 @@ class _FeedWidgetState extends State<FeedWidget> {
state.memes[index].imageLink,
cacheManager: cacheManager,
);

final key = renderedMemesKeys.putIfAbsent(
index,
() => GlobalKey(),
Expand All @@ -126,20 +125,22 @@ class _FeedWidgetState extends State<FeedWidget> {
renderedMemes[index] = Size(cnstr.maxWidth, 200);
}

return ConstrainedBox(
constraints: BoxConstraints(
minHeight: 200,
// maxHeight: maxHeight,
maxWidth: cnstr.maxWidth,
),
child: OctoImage(
// Using [AnimatedVisibilityWithReversedDuration] to
// hide with animation selected post and show immediately
// if its not. Its because of postWidget, it will re-render
// any error images, so they will reload, and this and post
// widgets will have different state, but overlaping each other
return AnimatedVisibilityWithReversedDuration(
duration: const Duration(milliseconds: 300),
reversedDuration: Duration.zero,
visibility: index != state.iterator,
child: FeedImage(
key: key,
image: imageProvider,
fit: BoxFit.fitWidth,
progressIndicatorBuilder: (context, progress) =>
Lottie.asset(
'lib/assets/animations/space_loader.json',
),
imageProvider: imageProvider,
constraints: cnstr,
onRefreshPressed: () => setState(() {
renderedMemesKeys[index] = GlobalKey();
}),
),
);
},
Expand Down Expand Up @@ -215,6 +216,7 @@ class _FeedWidgetState extends State<FeedWidget> {
WidgetsBinding.instance!.addPostFrameCallback(
(_) => setState(() {
renderedMemes[index] = size;
print('index $index is $size');
imageProvider
.resolve(ImageConfiguration.empty)
.removeListener(listener);
Expand Down
61 changes: 32 additions & 29 deletions lib/presentation/screens/feed/post_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@ import 'package:devour/application/feed/bloc/feed_bloc.dart';
import 'package:devour/domain/meme/abstract_meme_model.dart';
import 'package:devour/domain/misc/helper.dart';
import 'package:devour/injection.dart';
import 'package:devour/presentation/screens/feed/feed_image_widget.dart';
import 'package:devour/presentation/widgets/platform/platform_icon_button.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
import 'package:octo_image/octo_image.dart';

class PostWidget extends StatelessWidget {
/// Widget to show post information like description and likes and image,
/// to create illusion of selecting meme from list.
class PostWidget extends StatefulWidget {
/// Constructs PostWidget
const PostWidget(
this.state, {
required this.constraints,
Expand All @@ -22,13 +25,19 @@ class PostWidget extends StatelessWidget {
final FeedState state;
final BoxConstraints constraints;

@override
State<PostWidget> createState() => _PostWidgetState();
}

class _PostWidgetState extends State<PostWidget> {
@override
Widget build(BuildContext context) {
if (state.isLoading) {
if (widget.state.isLoading) {
return Container();
}

final key = state.currentMemeWidget.toNullable();
final key = widget.state.currentMemeWidget.toNullable();
// key.currentWidget
final box = key?.currentContext?.findRenderObject() as RenderBox?;
final pos = box?.localToGlobal(Offset.zero) ?? Offset.zero;

Expand All @@ -41,41 +50,35 @@ class PostWidget extends StatelessWidget {
height: box?.size.height,
child: IgnorePointer(
child: AnimatedSwitcher(
duration: const Duration(milliseconds: 100),
layoutBuilder: (curr, prev) {
return Stack(
alignment: Alignment.center,
children: <Widget>[
// ...prev,
if (curr != null) curr,
],
);
},
child: ConstrainedBox(
key: Key(state.currentMemeModel.imageLink),
constraints: BoxConstraints(
minWidth: constraints.maxWidth,
),
child: OctoImage(
image: CachedNetworkImageProvider(
state.currentMemeModel.imageLink,
errorListener: () =>
print('error (${state.currentMemeModel.imageLink})'),
duration: const Duration(milliseconds: 100),
layoutBuilder: (curr, prev) {
return Stack(
alignment: Alignment.center,
children: <Widget>[
// ...prev,
if (curr != null) curr,
],
);
},
child: FeedImage(
key: Key(widget.state.currentMemeModel.imageLink),
imageProvider: CachedNetworkImageProvider(
widget.state.currentMemeModel.imageLink,
errorListener: () => print(
'error (${widget.state.currentMemeModel.imageLink})'),
cacheManager: serviceLocator<CacheManager>(),
),
fit: BoxFit.fitWidth,
width: constraints.maxWidth,
constraints: widget.constraints,
),
),
),
),
),
Positioned.fill(
top: 100,
child: Row(
mainAxisAlignment: MainAxisAlignment.end,
children: [
PostActionsWidget(currentPost: state.currentMemeModel),
PostActionsWidget(currentPost: widget.state.currentMemeModel),
],
),
),
Expand All @@ -84,7 +87,7 @@ class PostWidget extends StatelessWidget {
bottom: 100,
width: 400,
child: PostDescriptionWidget(
currentPost: state.currentMemeModel,
currentPost: widget.state.currentMemeModel,
),
),
],
Expand Down
67 changes: 67 additions & 0 deletions lib/presentation/widgets/animations/animated_opacity_reverse.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import 'package:flutter/material.dart';

/// Like [AnimatedOpacity], but with control over [reversedDuration]
class AnimatedVisibilityWithReversedDuration extends StatefulWidget {
/// Constructs AnimatedVisibilityWithReversedDuration
const AnimatedVisibilityWithReversedDuration({
Key? key,
required this.duration,
required this.visibility,
required this.child,
Duration? reversedDuration,
}) : reversedDuration = reversedDuration ?? duration,
super(key: key);

final Duration duration;
/// Reversed duration. If null - [duration] will be used
final Duration reversedDuration;
final bool visibility;
final Widget child;

@override
State<AnimatedVisibilityWithReversedDuration> createState() =>
_AnimatedVisibilityWithReversedDurationState();
}

class _AnimatedVisibilityWithReversedDurationState
extends State<AnimatedVisibilityWithReversedDuration>
with TickerProviderStateMixin {
late AnimationController controller;

@override
void initState() {
super.initState();
controller = AnimationController(
vsync: this,
duration: widget.reversedDuration,
reverseDuration: widget.duration,
value: 1.0,
);
}

@override
void didUpdateWidget(
covariant AnimatedVisibilityWithReversedDuration oldWidget,
) {
if (oldWidget.visibility != widget.visibility) {
if (widget.visibility) {
controller.forward();
} else {
controller.reverse();
}
}
super.didUpdateWidget(oldWidget);
}

@override
Widget build(BuildContext context) => AnimatedBuilder(
animation: controller,
child: widget.child,
builder: (context, child) {
return Opacity(
opacity: controller.value,
child: child,
);
},
);
}
3 changes: 2 additions & 1 deletion lib/presentation/widgets/platform/platform_icon_button.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class PlatformIconButton
final double size;
final Color color;
final String text;
final VoidCallback onPressed;
final VoidCallback? onPressed;

@override
CupertinoButton buildCupertino(BuildContext context) {
Expand Down Expand Up @@ -52,6 +52,7 @@ class PlatformIconButton
];

return Column(
mainAxisSize: MainAxisSize.min,
children: [
Text(
String.fromCharCode(icon.codePoint),
Expand Down