Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow for any parameter to be exposed in UI. (e.g. pingpong) #30

Open
dpm316 opened this issue Jan 13, 2025 · 1 comment
Open
Labels
enhancement New feature or request Feature Request A feature that you want added

Comments

@dpm316
Copy link

dpm316 commented Jan 13, 2025

My imported workflow contains a VHS_VideoCombine node that has a pingpong boolean parameter. I can hardcode the value in the workflow file (I actually created separate workflows for true/false values as a workaround to this issue), but I can't figure out how to expose this parameter in the UI. I thought it would be as simple as adding it to the end of the json file.

already in the json file:
"78": {
"inputs": {
"frame_rate": "24",
"loop_count": "0",
"filename_prefix": "comfyui_hunyaun",
"format": "image/webp",
"pix_fmt": "yuv420p",
"crf": 19,
"save_metadata": true,
"pingpong": false,
"save_output": true,
"images": [
"73",
0
]
},

I added the following to the "input_options" section:
{
"node_id": "78",
"input_name_in_node": "pingpong",
"title": "pingpong"
}

It didn't work. No parameters are showing up in the UI with this change. When I revert the change, the UI is working again. Is there another change I need to make to get have the parameter show up in the UI? Thanks!

@dpm316 dpm316 added enhancement New feature or request Feature Request A feature that you want added labels Jan 13, 2025
@dpm316
Copy link
Author

dpm316 commented Jan 15, 2025

I have a workaround for ComfyUI Mini not supporting boolean params. There is an int to bool custom node in comfy_mtb. I converted the pingpong param to an input and connected this node which is recognized by Mini! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feature Request A feature that you want added
Projects
None yet
Development

No branches or pull requests

1 participant