Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further obscure communities UI #148

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

cc-a
Copy link
Collaborator

@cc-a cc-a commented Feb 20, 2025


This PR further obscures the communities feature in the web UI by:

  • Updating "new upload" ui elements to href to /uploads/new?community=icl. This has the effect of pre-selecting the community into which the record will be submitted. This of course presupposes that a community with the identifier 'icl' exists. For the time being this must be created manually.
  • Hiding the community header on the deposit form.
  • Hiding a "new upload" element that was difficult to update in the event of a no results being returned on the user uploads list page.

Note this PR is based on the onboarding-docs branch (from #147) as wanted to make sure these further customisations were captured in the docs. I'll rebase it once #147 is merged.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant