fix: Realm doesn't fail silently anymore when trying to update upload…

…ed Attachments
Infomaniak · Mar 7, 2025 · 3f6ee11 · 3f6ee11
1 parent f48fa20
commit 3f6ee11
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/src/main/java/com/infomaniak/mail/utils/DraftUtils.kt b/app/src/main/java/com/infomaniak/mail/utils/DraftUtils.kt
@@ -51,8 +51,9 @@ private suspend fun Draft.uploadAttachments(mailbox: Mailbox, draftController: D
         it.attachmentUploadStatus == AttachmentUploadStatus.AWAITING
     }
 
-    suspend fun setUploadStatus(attachment: Attachment, uploadStatus: AttachmentUploadStatus, step: String) {
-        realm.write {
+    fun setUploadStatus(attachment: Attachment, uploadStatus: AttachmentUploadStatus, step: String) {
+        // This `writeBlocking` is on purpose. A simple `write` here will fail silently.
+        realm.writeBlocking {
             draftController.updateDraft(localUuid, realm = this) {
                 it.attachments.findSpecificAttachment(attachment)?.setUploadStatus(uploadStatus, draft = it, step)
             }

diff --git a/app/src/main/java/com/infomaniak/mail/utils/extensions/AttachmentExtensions.kt b/app/src/main/java/com/infomaniak/mail/utils/extensions/AttachmentExtensions.kt
@@ -169,13 +169,14 @@ object AttachmentExtensions {
         }
     }
 
-    private suspend fun Attachment.updateLocalAttachment(
+    private fun Attachment.updateLocalAttachment(
         draftLocalUuid: String,
         remoteAttachment: Attachment,
         draftController: DraftController,
         realm: Realm,
     ) {
-        realm.write {
+        // This `writeBlocking` is on purpose. A simple `write` here will fail silently.
+        realm.writeBlocking {
             draftController.updateDraft(draftLocalUuid, realm = this) { draft ->
 
                 val uuidToLocalUri = draft.attachments.map { it.uuid to it.uploadLocalUri }