Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose similar safeNavigate method in ThreadFragment as other fragments have #1660

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Jan 18, 2024

To simplify future addition of navigations from the ThreadFragment, all the variables and methods that had to be created are now simplified in a single safeNavigate() method that works just like the one in any other Fragment

@LunarX LunarX added the enhancement Improve or expand upon an existing feature label Jan 18, 2024
@LunarX LunarX requested a review from KevinBoulongne January 18, 2024 12:38
@LunarX LunarX self-assigned this Jan 18, 2024
@LunarX LunarX requested a review from a team as a code owner January 18, 2024 12:38
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jan 22, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jan 22, 2024
@KevinBoulongne KevinBoulongne force-pushed the refctor-thread-fragement-nav branch from 943769e to bd48057 Compare January 22, 2024 08:02
@LunarX LunarX force-pushed the refctor-thread-fragement-nav branch from bd48057 to 70b8978 Compare January 22, 2024 08:03
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit bc52681 into master Jan 22, 2024
3 checks passed
@KevinBoulongne KevinBoulongne deleted the refctor-thread-fragement-nav branch January 22, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or expand upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants