Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Folder name when we search/read a Thread #1699

Merged
merged 36 commits into from
Feb 21, 2024
Merged

Display Folder name when we search/read a Thread #1699

merged 36 commits into from
Feb 21, 2024

Conversation

tevincent
Copy link
Contributor

@tevincent tevincent commented Feb 8, 2024 •
edited
Loading

folder_name_compact_expand.mp4

@tevincent tevincent requested a review from a team as a code owner February 8, 2024 10:20
@tevincent tevincent force-pushed the folder_message_search branch from 202dc6a to ca374aa Compare February 8, 2024 13:57
@Infomaniak Infomaniak deleted a comment from sonarqubecloud bot Feb 8, 2024
@Infomaniak Infomaniak deleted a comment from sonarqubecloud bot Feb 8, 2024
@tevincent tevincent marked this pull request as draft February 9, 2024 08:32
@tevincent tevincent marked this pull request as ready for review February 9, 2024 12:36
@tevincent tevincent marked this pull request as draft February 9, 2024 14:04
@tevincent tevincent marked this pull request as ready for review February 12, 2024 07:35
LunarX
LunarX requested changes Feb 12, 2024
View reviewed changes
@tevincent tevincent force-pushed the folder_message_search branch from e6a823f to de4ebc8 Compare February 15, 2024 11:51
LunarX
LunarX requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments

@tevincent tevincent force-pushed the folder_message_search branch 2 times, most recently from a83d543 to 26031ff Compare February 15, 2024 14:04
LunarX
LunarX requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

@tevincent tevincent force-pushed the folder_message_search branch from 26031ff to 4ad3340 Compare February 15, 2024 14:24
LunarX
LunarX requested changes Feb 15, 2024
View reviewed changes
@KevinBoulongne KevinBoulongne added the feature Add a new function or capability to the project label Feb 16, 2024
KevinBoulongne
KevinBoulongne requested changes Feb 16, 2024
View reviewed changes
@KevinBoulongne KevinBoulongne changed the title Add folder name when we search a mail and when we read a mail Display Folder name when we search/read a Thread Feb 16, 2024
@tevincent tevincent force-pushed the folder_message_search branch from 981d1e5 to 309bdb2 Compare February 16, 2024 08:07
@KevinBoulongne KevinBoulongne force-pushed the folder_message_search branch 5 times, most recently from dcb6d38 to 812b535 Compare February 16, 2024 10:20
tevincent and others added 26 commits February 21, 2024 16:27
@tevincent @LunarX
Add folder name to thread only if we have one message
6f95591
@tevincent @LunarX
Add let parameter name
b260bd9
@tevincent @LunarX
Get localized folder name
a8abd45
@tevincent @LunarX
Pass folder name visibility to adapter directly in the constructor
16ca746
@tevincent @LunarX
Rename method
8461d7e
@tevincent @LunarX
Clean layout of thread
20baae0
@tevincent @LunarX
Create a container for icons
5fa8416 
wip Reorganize subject formatting methods

Code review
@tevincent @LunarX
Add other folder name view for compact mode and expand mode
b20c10e
@tevincent @LunarX
create a method to reset folder name visibility
96a087e
@tevincent @LunarX
Code review
e98a6d9
@tevincent @LunarX
Update app/src/main/java/com/infomaniak/mail/ui/main/thread/SubjectFo…
43fc7c3 
…rmatter.kt

Co-authored-by: Gibran Chevalley <32095402+LunarX@users.noreply.github.com>
@tevincent @LunarX
Code review
dfd6fe5
@KevinBoulongne @LunarX
Remove ThreadDensity imports
032b262
@KevinBoulongne @LunarX
Revamp displayFolderName() visibility handling
a951fd5
@KevinBoulongne @LunarX
Extract Folder name computation to its own function
b1c86b7
@tevincent @LunarX
Code review of Kevin B.
d39a255
@KevinBoulongne @LunarX
Reformat code
93f0005
@KevinBoulongne @LunarX
Move TagColor data class to SubjectFormatter
522e53d
@LunarX
Intuitively set the visibility of folder names
e14f854
@tevincent @LunarX
Rename color for foldername
ce84f9e
@tevincent @LunarX
Remove unused method
d6edcfd
@tevincent @LunarX
Code review
a0e0fb7
@tevincent @LunarX
Simplify code to ellipsize or not tags in subject
42ce25c
@tevincent @LunarX
Rename variable
d964857
@LunarX
Cache folder ids when reading folder names from realm
59625b2
@LunarX
Measure tag's actual width to know when to ellipsize or not
91794f4
@LunarX LunarX force-pushed the folder_message_search branch from eef7adf to 91794f4 Compare February 21, 2024 15:28
@LunarX LunarX merged commit 0f942a1 into master Feb 21, 2024
3 checks passed
@LunarX LunarX deleted the folder_message_search branch February 21, 2024 15:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

@KevinBoulongne KevinBoulongne Awaiting requested review from KevinBoulongne

Assignees

@tevincent tevincent

Labels
feature Add a new function or capability to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevincent @KevinBoulongne @LunarX