fix: Select date time dialog wrong values and wrong error messages #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message would stay when it should not have or would not show we it should have been there. This commit fixes this issue by centralizing the way to set a new selectedDate
…erial date picker
TommyDL-Infomaniak
approved these changes
Feb 18, 2025
TommyDL-Infomaniak
approved these changes
Feb 18, 2025
Fixing this required to update the design in order for text fields to be on different lines because there's not enough space to display them side by side on small screens otherwise
|
tevincent
requested changes
Feb 18, 2025
app/src/main/res/layout/dialog_select_date_and_time_for_scheduled_draft.xml
Show resolved
Hide resolved
|
And you have 3 SonarCloud issues. I think you can just mark them as |
|
The sonar issues are actually false positive, this is some custom code of ours not a deprecated api. But yeah, I handled it thanks for notifying me |
tevincent
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message sometimes not block the user when it should've or it would would block the user when it should not have. The values inside the time picker would also sometime be wrong and have a different one than the one displayed inside the dialog