Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix notification worker #2200

Merged
merged 3 commits into from
Feb 26, 2025
Merged

fix: Fix notification worker #2200

merged 3 commits into from
Feb 26, 2025

Conversation

FabianDevel
Copy link
Contributor

No description provided.

@FabianDevel FabianDevel added bug Something isn't working quick A pull request consisting of a few lines labels Feb 26, 2025
@FabianDevel FabianDevel changed the title Fix notification worker fix: Fix notification worker Feb 26, 2025
@LouisCAD LouisCAD self-requested a review February 26, 2025 09:28
LouisCAD
LouisCAD approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test locally, but everything looks good to me.

@FabianDevel FabianDevel disabled auto-merge February 26, 2025 09:46
@FabianDevel FabianDevel force-pushed the fix-notification-worker branch from e70881d to b632b09 Compare February 26, 2025 09:48
@FabianDevel FabianDevel force-pushed the fix-notification-worker branch from b632b09 to f1a4810 Compare February 26, 2025 09:49
@FabianDevel FabianDevel force-pushed the fix-notification-worker branch from f1a4810 to 6e86f3c Compare February 26, 2025 09:55
LouisCAD
LouisCAD approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better. Hopefully we bring our CI runners back to life.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FabianDevel FabianDevel merged commit 914c80c into master Feb 26, 2025
6 checks passed
@FabianDevel FabianDevel deleted the fix-notification-worker branch February 26, 2025 10:28
KevinBoulongne pushed a commit that referenced this pull request Feb 26, 2025
@FabianDevel @KevinBoulongne
fix: Fix notification worker (#2200)
0f83aff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

@LouisCAD LouisCAD LouisCAD approved these changes

@tevincent tevincent tevincent approved these changes

Assignees

@FabianDevel FabianDevel

Labels
bug Something isn't working quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FabianDevel @KevinBoulongne @LouisCAD @tevincent