Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Directly delete Messages in Realm, it will automatically remove them from their Threads #2217

Merged
merged 1 commit into from
Mar 5, 2025
Merged

refactor: Directly delete Messages in Realm, it will automatically remove them from their Threads #2217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/RefreshController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,21 +449,8 @@ class RefreshController @Inject constructor(

shortUids.forEach { shortUid ->
scope.ensureActive()

val message = MessageController.getMessage(uid = shortUid.toLongUid(folderId), realm = this) ?: return@forEach

/**
* This list is reversed because we'll delete items while looping over it.
* Doing so for managed Realm objects will lively update the list we're iterating through, making us skip the next item.
* Looping in reverse enables us to not skip any item.
*/
message.threads.asReversed().forEach { thread ->
scope.ensureActive()

val isSuccess = thread.messages.remove(message)
if (isSuccess) threads += thread
}

threads += message.threads
MessageController.deleteMessage(appContext, mailbox, message, realm = this)
}

Expand Down