Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter snooze in folders #2221

Merged
merged 13 commits into from
Mar 7, 2025
Merged

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Mar 5, 2025

Queries different threads in realm to choose what threads will be part of the snooze folder and the inbox folder. To do so, I introduce a RefreshStrategy so multiple folders can define different logics for the same step of the refresh algorithm.

This will also help us easily keep track of what bit of logic is different for the snooze folder if the API ever sends us more normal data for the snooze folder

Depends on #2220

@LunarX LunarX added the enhancement Improve or expand upon an existing feature label Mar 5, 2025
@LunarX LunarX requested a review from KevinBoulongne March 5, 2025 14:25
@LunarX LunarX self-assigned this Mar 5, 2025
@github-actions github-actions bot added the dependent This MR depends on another PR label Mar 5, 2025
@LunarX LunarX force-pushed the filter-snooze-in-folders branch from 6e0ba07 to 29d4da8 Compare March 6, 2025 07:26
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 0709843 to 45e5401 Compare March 6, 2025 13:19
@KevinBoulongne KevinBoulongne force-pushed the snooze branch 2 times, most recently from 6cafe10 to 4f49408 Compare March 7, 2025 07:17
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 76fe917 to 562e803 Compare March 7, 2025 07:17
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 562e803 to 42f92c3 Compare March 7, 2025 07:36
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 42f92c3 to e83bd30 Compare March 7, 2025 08:19
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from e83bd30 to f7b740d Compare March 7, 2025 08:25
Base automatically changed from snooze to snooze-feature-branch March 7, 2025 08:33
@github-actions github-actions bot removed the dependent This MR depends on another PR label Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

This PR/issue depends on:

@LunarX LunarX enabled auto-merge March 7, 2025 08:51
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 0b6bef8 to 8fc41c1 Compare March 7, 2025 08:54
Copy link

sonarqubecloud bot commented Mar 7, 2025

@LunarX LunarX merged commit b227e62 into snooze-feature-branch Mar 7, 2025
6 checks passed
@LunarX LunarX deleted the filter-snooze-in-folders branch March 7, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or expand upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants