Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce custom logic to handle deleted uids in the case of the snooze folder #2222

Open
wants to merge 13 commits into
base: upsert-remote-instead-of-updating-local
Choose a base branch
from

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Mar 5, 2025

Defines the custom logic to handle deleted uids for the snooze folder. It leverages the RefreshStrategy to define the custom logic.

Inside this PR there's an issue where the snooze folder is not refreshed after an action on a message. This is fixed in the very next PR.

Depends on #2234

@LunarX LunarX added the enhancement Improve or expand upon an existing feature label Mar 5, 2025
@LunarX LunarX requested a review from KevinBoulongne March 5, 2025 14:28
@LunarX LunarX self-assigned this Mar 5, 2025
@github-actions github-actions bot added the dependent This MR depends on another PR label Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

@LunarX LunarX force-pushed the refresh-strategy-for-deleted branch from b1042da to 2b7f41d Compare March 6, 2025 07:26
@LunarX LunarX force-pushed the filter-snooze-in-folders branch from 6e0ba07 to 29d4da8 Compare March 6, 2025 07:26
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 0709843 to 45e5401 Compare March 6, 2025 13:19
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch 2 times, most recently from e7ea42e to 332316b Compare March 6, 2025 14:00
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch 2 times, most recently from 562e803 to 42f92c3 Compare March 7, 2025 07:36
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from 332316b to e49d531 Compare March 7, 2025 07:44
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from 42f92c3 to e83bd30 Compare March 7, 2025 08:19
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from e49d531 to b95d1b0 Compare March 7, 2025 08:20
@KevinBoulongne KevinBoulongne force-pushed the filter-snooze-in-folders branch from e83bd30 to f7b740d Compare March 7, 2025 08:25
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from b95d1b0 to f203493 Compare March 7, 2025 08:36
@KevinBoulongne KevinBoulongne changed the base branch from filter-snooze-in-folders to extract-addedMessages-in-refreshStrategy March 7, 2025 08:39
@KevinBoulongne KevinBoulongne force-pushed the extract-addedMessages-in-refreshStrategy branch 5 times, most recently from 8514b16 to 47dc8ca Compare March 7, 2025 09:07
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch 2 times, most recently from 254902d to 58617df Compare March 7, 2025 09:31
@KevinBoulongne KevinBoulongne changed the base branch from extract-addedMessages-in-refreshStrategy to upsert-remote-instead-of-updating-local March 7, 2025 09:31
@KevinBoulongne KevinBoulongne force-pushed the upsert-remote-instead-of-updating-local branch from 0aefee7 to 38f558f Compare March 7, 2025 09:47
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from 58617df to fc73910 Compare March 7, 2025 09:47
@KevinBoulongne KevinBoulongne force-pushed the upsert-remote-instead-of-updating-local branch from 38f558f to 8d55c21 Compare March 7, 2025 12:21
@KevinBoulongne KevinBoulongne force-pushed the refresh-strategy-for-deleted branch from 280ebc3 to 22e5c6f Compare March 7, 2025 12:21
Copy link

sonarqubecloud bot commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent This MR depends on another PR enhancement Improve or expand upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants