Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dependencies security issues #316

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Mar 19, 2024

  • Updated aiohttp dependency version to solve a security issue detected by Dependabot
  • Removed version restriction for urllib3 since the latest version is not causing issues with the unit tests anymore

Summary by CodeRabbit

  • Chores
    • Updated aiohttp dependency version to ">=3.9.2" to address a security vulnerability.
    • Incremented project version to "1.4.2".

Copy link
Contributor

coderabbitai bot commented Mar 19, 2024

Walkthrough

This update primarily addresses a security vulnerability by upgrading the aiohttp dependency to version ">=3.9.2". It also involves a minor version bump for the project from "1.4.1" to "1.4.2". This change ensures compatibility and enhances security by incorporating the latest aiohttp improvements, specifically catering to the needs of the Injective Labs SDK Python project.

Changes

File(s) Change Summary
CHANGELOG.md, pyproject.toml Updated aiohttp version to ">=3.9.2"; incremented project version to "1.4.2".

🐇✨
In the realm of code, under digital skies,
A tiny hop forward, a leap for the wise.
With aiohttp now secure and sound,
Our project's safety is newly found.
So here's to the changes, small but mighty,
Guiding us through, ever so brightly.
🌟📚


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (1a4abc3) to head (6753d79).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   76.25%   76.25%           
=======================================
  Files          50       50           
  Lines        4111     4111           
  Branches      351      351           
=======================================
  Hits         3135     3135           
  Misses        871      871           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarmoa aarmoa merged commit db9b6c0 into master Mar 19, 2024
12 checks passed
@aarmoa aarmoa deleted the fix/dependencies_security_issues branch March 19, 2024 15:01
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 1a4abc3 and 6753d79.
Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • poetry.lock (8 hunks)
  • pyproject.toml (3 hunks)
Files not summarized due to errors (1)
  • poetry.lock: Error: Message exceeds token limit
Additional comments: 12
pyproject.toml (3)
  • 3-3: The version increment from "1.4.1" to "1.4.2" in the tool.poetry section is appropriate given the dependency updates for security reasons.
  • 25-25: Updating aiohttp to ">=3.9.2" addresses the security vulnerability identified by Dependabot. This is a crucial update for maintaining the security integrity of the project.
  • 38-38: Removing the version restriction for urllib3 by setting it to "*" suggests confidence in the compatibility of the latest versions with the project. However, it's important to ensure that this change has been thoroughly tested across the project's functionalities to avoid unexpected issues.
CHANGELOG.md (1)
  • 5-7: The changelog correctly documents the update of the aiohttp dependency version to ">=3.9.2" to address a security vulnerability. This entry provides clear information on the changes made in version 1.4.2.
poetry.lock (8)
  • 638-694: The update to the coverage package with new file hashes across different Python versions and platforms looks standard and appropriate.
  • 1233-1295: The update to the grpcio package to version 1.62.1 with new file hashes for different Python versions and platforms is standard and looks good.
  • 1723-1729: The update to the packaging package to version 24.0 is a routine update and looks appropriate.
  • 1915-1937: The update to the pytest package to version 8.1.1, including new file hashes and dependency adjustments, is standard and looks good.
  • 2093-2099: The update to the referencing package to version 0.34.0 is a routine update and looks appropriate.
  • 2388-2399: The update to the setuptools package to version 69.2.0, including new file hashes and adjustments to extras dependencies, is standard and looks good.
  • 2459-2472: The update to the urllib3 package to version 2.2.1, including new file hashes and extras dependencies, aligns with the PR objectives and represents a significant compatibility and security improvement.
  • 2716-2716: The update to the metadata section with a new content-hash is a standard procedure following the updates in the lock file and looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant