-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/refactor_network_mixed_secure_insecure_channels #319
feat/refactor_network_mixed_secure_insecure_channels #319
Conversation
WalkthroughThe changes involve deprecating the Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
tests/test_async_client_deprecation_warnings.py (1)
Line range hint
583-583
: Duplicate method nametest_stream_keepalive_deprecation_warning
found. This could lead to one of the methods being overshadowed and not tested. Please rename one of the methods to ensure both are uniquely identifiable and executable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
tests/test_async_client_deprecation_warnings.py (1)
Line range hint
583-583
: Duplicate method definition fortest_stream_keepalive_deprecation_warning
. Consider removing or renaming one of the definitions to ensure all tests are executed as expected.
use_secure_connection
as deprecated.Solves CHAIN-89
Summary by CodeRabbit
use_secure_connection
andcredentials
parameters in favor of more flexible connection handling.