Skip to content

feat: added art/grid API endpoint #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RustyNova016
Copy link
Contributor

Added this api endpoint. Since the documentation is quite vague about it, I expended some comments, and added an exemple (it doesn't actually run. It only try to compile)

#31 need to pass first, as I based it on this branch.

@shymega
Copy link
Collaborator

shymega commented Feb 15, 2025

Can we mark this PR as draft until #31 is merged, and then rebase this PR on mainline once #31 is merged?

Cheers :)

@RustyNova016
Copy link
Contributor Author

I wasn't sure if I should put it as draft. But I'll do it when back to pc as GitHub mobile doesn't seem to have the features

@InputUsername InputUsername marked this pull request as draft February 16, 2025 13:11
@shymega
Copy link
Collaborator

shymega commented Feb 16, 2025

Thanks @InputUsername =)

@shymega shymega marked this pull request as ready for review February 19, 2025 22:58
@shymega shymega added this to the v0.8.2 milestone Feb 19, 2025
@RustyNova016
Copy link
Contributor Author

Sorry for the absence, I was sick all weekend (yay).

It seems like native-tls has updated their MSRV to 1.80, and not a me problem. This would be fine if the users use the new cargo resolver, but it's opt-in in 1.84 and default in 1.85 (which is releasing today)...
Guess we are forced to bump to 1.80? Not a great thing as this is a pretty high MSRV IMO

@shymega shymega enabled auto-merge February 20, 2025 18:40
@shymega
Copy link
Collaborator

shymega commented Feb 20, 2025

@InputUsername It also seems the PR I merged yesterday wasn't rebased, so CI didn't warn us about the MSRV job failing.

We need to have a discussion - in a separate issue maybe? -- about going forward with MSRV.

@RustyNova016
Copy link
Contributor Author

RustyNova016 commented Feb 21, 2025

The previous PR has been revised tho? And the msrv check passed.

Probably an update happened between the checks

Edit: that new version is freshly out:
https://crates.io/crates/native-tls/versions

@InputUsername
Copy link
Owner

InputUsername commented Feb 22, 2025

@InputUsername It also seems the PR I merged yesterday wasn't rebased, so CI didn't warn us about the MSRV job failing.

We need to have a discussion - in a separate issue maybe? -- about going forward with MSRV.

I've made #47 to continue the discussion.

@shymega shymega force-pushed the feat/art-grid branch 2 times, most recently from 800bed9 to 3abddec Compare February 25, 2025 20:06
@shymega
Copy link
Collaborator

shymega commented Feb 25, 2025

@RustyNova016 You'll need to git pull --rebsae on this branch, as I've rebased against main.

auto-merge was automatically disabled February 27, 2025 07:33

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants