Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to select all source #39

Open
rosehartman opened this issue May 23, 2023 · 3 comments
Open

option to select all source #39

rosehartman opened this issue May 23, 2023 · 3 comments

Comments

@rosehartman
Copy link
Contributor

I was pulling a bunch of data and it would be nice to have Source = "ALL" or something to pull all the potential sources rather than having to list them all. I can work on this (I think).

@sbashevkin
Copy link
Collaborator

That's how the package originally worked, but then when I was adding new data sources, it was changing the behavior of older code since the definition of "all" will change each time a new dataset is added. So I moved to forcing people to type out all the data sources they want, which is more future-proof (and makes people think about which data sources to use). But I'd be open to thoughts from you and @mountaindboz

@mountaindboz
Copy link
Collaborator

Yeah, I could go either way on this. I think we can write the wq to default to all sources and still have it be easy to update when adding new data sources. But I could also see the advantage of making people be explicit about what data sources they want to integrate. That being said, I have usually used wq to integrate all sources.

@rosehartman
Copy link
Contributor Author

Hm. I would lean toward having it default to all sources, since that's how I usually use the package, but I can see both sides. I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants