Twentymill #32
Merged
Twentymill #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed column names to match new data, updated cross walks with capitalized taxon names, added new station coordinates.
This is based on conversation with Christina and comparing results for taxa wehre we have both.
|
Dang it, That test passed on my computer, I'll see what the problem is. |
sbashevkin
reviewed
Jun 25, 2024
R/zoop_downloader.R
Outdated
| -"Dilution", -"SampleID", -"Datetime"), | ||
| names_to="twentymm_Meso", values_to="CPUE")%>% #transform from wide to long | ||
| dplyr::mutate(Turbidity = dplyr::coalesce(NTU, FNU)) %>% #NTU and FNU are close enough it's not a big deal to treat them as the same |
There was a problem hiding this comment.
I've heard wildly different opinions on this. For the water quality and fish integrated datasets, we've moved to separate columns for NTU and FNU ("TurbidityFNU", "TurbidityNTU"). Maybe we should do the same with zooper?
There was a problem hiding this comment.
Ugh. Sigh. I suppose you're probably right. I can make that change.
There was a problem hiding this comment.
Sorry. I can make the change for the other surveys if it's too much trouble
There was a problem hiding this comment.
Naw, I got it! All the other surveys use NTU, so it's just renaming them. I'm already halfway through testing the update.
sbashevkin
merged commit fc11a42
into
InteragencyEcologicalProgram:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 20mm survey got their 2021 and 2022 data up, and there were some minor format changes. I updated the code to account for new column names, and addition of a few stations.
Christina and I have also been taking a deep dive into lenght-weight regressions, and we think we should be using 0.25 instead of 0.1 to convert amphipod wet weight to dry weight.