Skip to content

Move withdrawals updating logic from CERTS to LEDGER #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soupstraw opened this issue Mar 18, 2025 · 1 comment
Open

Move withdrawals updating logic from CERTS to LEDGER #4932

Soupstraw opened this issue Mar 18, 2025 · 1 comment
Assignees
Labels
💳 technical-debt Issues related to technical debt we introduced

Comments

@Soupstraw
Copy link
Contributor

Soupstraw commented Mar 18, 2025

It does not really make sense to update the withdrawals in the CERTS rule, since withdrawals have nothing to do with certificates. This is a remnant from Shelley and now in hindsight it makes much more sense to move this updating logic to LEDGER instead.

@Soupstraw Soupstraw added dijkstra Ledger era that will follow after Conway 💳 technical-debt Issues related to technical debt we introduced labels Mar 18, 2025
@Soupstraw Soupstraw changed the title Move withdrawals updating from CERTS to LEDGER Move withdrawals updating logic from CERTS to LEDGER Mar 18, 2025
@lehins lehins removed the dijkstra Ledger era that will follow after Conway label Mar 18, 2025
@lehins
Copy link
Collaborator

lehins commented Mar 18, 2025

This we can do now. I meant once we implement this ticket, which we can do now, we need to create a ticket about moving the actual predicate failure in Dijkstra era from CERTS to LEDGER. So, I removed the Dijkstra label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants