Skip to content

Revert Annotator removal #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lehins opened this issue Apr 18, 2025 · 0 comments
Open

Revert Annotator removal #5003

lehins opened this issue Apr 18, 2025 · 0 comments
Labels
💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Collaborator

lehins commented Apr 18, 2025

PR #4968 needs to be reverted

Attempt to integrate removal of Annotator into consensus and network layers:

  • revealed that Annotator approach is needed for decoding of blocks in streaming fashion
  • it also revealed that decoding in streaming fashion was never implemented in the network layer, but it needs to be. So, Network team will work on that.
  • incremental decoding of blocks is implemented in the consensus layer, when blocks are being fetched from immutable database. However, there was no functionality to
@lehins lehins added the 💳 technical-debt Issues related to technical debt we introduced label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Development

No branches or pull requests

1 participant