Replace Hashtables with generic ConcurrentDictionaries #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
reviewed
Oct 13, 2019
| using System.Runtime.InteropServices.ComTypes; | ||
| using System.Threading; | ||
|
|
||
| namespace Microsoft.Scripting.ComInterop { | ||
|
|
||
| public class ComTypeDesc : ComTypeLibMemberDesc { | ||
| private string _typeName; | ||
| private string _documentation; | ||
| //Hashtable is threadsafe for multiple readers single writer. |
There was a problem hiding this comment.
I have not looked at usage. But I assume this comment is here because it's intended to be used in multithreaded scenarios? Dictionary doesn't provide the same thread safety guarantees as Hashtable.
There was a problem hiding this comment.
I used ConcurrentDictionaries instead. What do you think?
There was a problem hiding this comment.
Using ConcurrentDictionary seems fine from a thread safety point of view. Hopefully it isn't a perf hit. Just need to find time to look at how these classes are used and will merge it in assuming there are no issues.
gpetrou
force-pushed
the
ReplaceHashtables
branch
from
d848e2a to
758fcdb
Compare
gpetrou
changed the title
|
This should probably be closed 🙂 |
|
I intended to do some performance measurements first to reach the right decision, merge or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.