Skip to content

Implement signal constants on POSIX platforms #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 14, 2025

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Apr 11, 2025

What has changed:

  • The values of existing constants in module signal are changed to reflect the actual values on a given platform (previously the values were always Windows-specific).
  • Missing signal constants are added for Unix signals.
  • test_signal from the IronPython test suite is modified to pass with CPython on all OS platforms supported by IronPython.
  • The implementation of module signal is modified to pass the modified test_signal. This in practice means primarily changes to error handling.

What has not changed:

  • The set and values of signal constants on Windows stays the same. For what I can see it is pretty complete.
  • Signal handling is the same (this means: on Windows SIGINT and SIGBREAK, and only SIGINT on Unix; no new signals are being handled yet).
  • No new (missing) functions are added to signal.

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@BCSharp BCSharp merged commit 2ac26e4 into IronLanguages:main Apr 14, 2025
17 checks passed
@BCSharp BCSharp deleted the signal_constants branch April 14, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants