Skip to content

Rename files with subclasses of PythonSignalState #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Apr 16, 2025

These two files contain other parts of partial class PythonSignal (implementing module signal) so they belong together with file signal.cs. With this rename they are sorted together with signal.cs when displayed in the file explorer.

This commit is factored out from a larger upcoming PR for signal, but for the sake of a clean git history of renames I prefer to keep it as a separate commit, rather than squashed together with other changes.

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. We could also consider preemptively adding the _ prefix _signal.NtSignalState.cs since in 3.5 the C module was renamed to _signal.

@BCSharp
Copy link
Member Author

BCSharp commented Apr 16, 2025

We could also consider preemptively adding the _ prefix _signal.NtSignalState.cs since in 3.5 the C module was renamed to _signal.

Not to defeat the purpose of this PR, this would require of renaming the existing signal.cs to _signal.cs as well. Unless you foresee problems with merges into 3.6, I'd keep the naming as is. I am counting on an assumption that with explicit renames like this one, merges should be easier as they should be able to track the file history across renames with 100% confidence.

@BCSharp
Copy link
Member Author

BCSharp commented Apr 16, 2025

To clarify: after the next merge to 3.6, rename signal.*.cs to _signal.*.cs on the 3.6 branch only in a separate commit.

@BCSharp BCSharp merged commit 2505d91 into IronLanguages:main Apr 17, 2025
17 checks passed
@BCSharp BCSharp deleted the signal_rename branch April 17, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants