Unregister signal handlers during engine shutdown #1953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is relevant for hosting scenarios. Importing module
signalin one IronPython engine registers a Ctrl+C signal handler, but it was not properly unregistered on engine shutdown. This means the handler was being referenced from the staticSystem.Console(on Windows I suppose from the callback marshalling code) and caused a memory leak and interference with another later instance of the engine (at best).The solution in this PR is to make
PythonSignalStatedisposable and modifyPythonContextthat it recognizes disposable module states. For good measure I implemented a finalizer too although I think it will never (i.e before process termination) be called because without a call toDispose()reference will stay alive and not being GC-ed.