✅ #133 simplify process to get custom preference entry values

.run/Unit tests.run.xml

@@ -1,6 +1,6 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="Unit tests" type="JavaScriptTestRunnerJest">
-    <config-file value="$PROJECT_DIR$/jest.config.json" />
+    <config-file value="$PROJECT_DIR$/tools/.jestrc.js" />
     <node-interpreter value="project" />
     <node-options value="" />
     <jest-package value="$PROJECT_DIR$/node_modules/jest" />

src/jagfx/application/components/menu/UserPreferenceTab/UserPreferenceList.vue

@@ -10,6 +10,10 @@
             <UserPreferenceListItemSelect
               configuration-id="general_refresh_rate"
             />
+            <UserPreferenceListItemSelect
+              configuration-id="general_skin_on_load"
+              :values="[{ label: 'One', value: 'Two' }]"
+            />
           </div>
         </div>
       </div>

src/jagfx/application/components/menu/UserPreferenceTab/item/UserPreferenceListItemSelect.vue

@@ -23,15 +23,23 @@ import { loadPreferenceEntryValues } from '@/jagfx/core/configuration/preference
 
 import UserPreferenceListItem from '@/jagfx/application/components/menu/UserPreferenceTab/UserPreferenceListItem.vue';
 
-defineProps({
+const props = defineProps({
   configurationId: {
     type: String,
     required: true
+  },
+  values: {
+    type: Array,
+    required: false,
+    default: () => []
   }
 });
 
-const loadValues = (preferenceEntry) =>
-  loadPreferenceEntryValues(preferenceEntry);
+const loadValues = (preferenceEntry) => {
+  return props.values.length > 0
+    ? props.values
+    : loadPreferenceEntryValues(preferenceEntry);
+};
 </script>
 
 <style lang="scss" scoped></style>

src/jagfx/core/configuration/preference-entry/loader.js

@@ -1,31 +1,5 @@
 export const loadPreferenceEntryValues = (preferenceEntry) => {
-  if (
-    Array.isArray(preferenceEntry) ||
-    preferenceEntry === null ||
-    typeof preferenceEntry !== 'object' ||
-    !Array.isArray(preferenceEntry.values) ||
-    !Object.hasOwnProperty.call(preferenceEntry, 'values') ||
-    preferenceEntry.values === null
-  ) {
-    return null;
-  }
-
-  if (
-    Array.isArray(preferenceEntry.values) &&
-    preferenceEntry.values.length > 0
-  ) {
-    return preferenceEntry.values;
-  }
-
-  if (
-    Array.isArray(preferenceEntry.values) &&
-    preferenceEntry.values.length === 0
-  ) {
-    // TODO Return loaded value
-    return [];
-  }
-
-  return null;
+  return preferenceEntry?.values ?? null;
 };
 
 // TODO Add test for it + tast to check all entry on map.json file