-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pre-process method #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made few comments, but I wuld be happy eitherway for most of them.
Happy with your comment above. Regarding the the enviroment variable, should we use something like that to evalusate them instead of a mapping?:
|
I like this as an idea but we are not passing them in as environment variables but as a defined list so I can't see how to get this to work. Unless we want to define it as an environment variable which I would prefer not to do because the define method makes the user do this explicitly. |
See also yp-data's help on how environment variables are mapped.
|
Thanks for the comments I have looked at the code on the I don't think for the preprocessor we would ever need to no process variables. |
@matthewrmshin if you are happy with this code could we get it in the stack I can them start testing the jjdoc / jjaux split which will enable us to get up to date |
Description
This PR addresses the second part of #25 by adding a new method which can be called using
yp-preprocessor
.Issue(s) addressed
Resolves #25
Dependencies
No dependencies.
Impact
None
Checklist