Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: use vanilla naming for town zones #800

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

WenSimEHRP
Copy link
Contributor

@WenSimEHRP WenSimEHRP commented Jan 2, 2025

Motivation / Problem

"Town Zones \d" is unclear and hard to understand.

Description

Use vanilla naming scheme, "outskirts", "centre", "inner suburbs" etc.
Change the townzone index, making it starting from 1.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@JGRennison
Copy link
Owner

Using the display names seems reasonable, but I do not see any need to renumber the zones.
The current values match the specification/documentation.

@WenSimEHRP
Copy link
Contributor Author

WenSimEHRP commented Jan 2, 2025

I've changed the numbering to match the specs

@JGRennison JGRennison merged commit cfb7477 into JGRennison:jgrpp Jan 5, 2025
10 checks passed
@JGRennison
Copy link
Owner

Thanks for this

@WenSimEHRP WenSimEHRP deleted the townzone-name branch January 5, 2025 19:16
telk5093 added a commit to telk5093/OpenTTD-patches that referenced this pull request Jan 12, 2025
telk5093 added a commit to telk5093/OpenTTD-patches that referenced this pull request Jan 12, 2025
JGRennison pushed a commit that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants