Use manual build mode for java-kotlin in codeql.yml
#865
Conversation
| # Only scan the plugin directory as the rest of the code is just sample code | ||
| working-directory: plugin | ||
| run: | | ||
| ./gradlew -p plugin --no-daemon --no-build-cache --console=plain --no-configuration-cache -x test -x check |
There was a problem hiding this comment.
This won't inject the init script that the autobuilder uses though. Don't we want the init script to configure Gradle correctly?
There was a problem hiding this comment.
calling github/codeql-action/init changes the environment variables in a way that anything done in between it and the finalize action will be analyzed by CodeQL. Technically it uses LD_PRELOAD on Linux, and INSERT_DYLD_LIBRARIES on macOS. On windows there is another slightly different mechanism, and we do require running commands under a special runner. On macOS we may need a runner as well if the build is not wrapped into a non-system runner (so ./gradlew would work). On Linux it just works 🙂
There was a problem hiding this comment.
I added a bit more to the concerns I have with this solution here:
I'm willing to accept this solution for now, but I think long-term this is masking a larger problem and is leaving build speed on the ground because of how the build-cache is entirely disabled
There was a problem hiding this comment.
ah, I see what you meant now, that's a gradle init script I wasn't aware of.
There was a problem hiding this comment.
I'll merge this for now, but I think the larger problem still remains regarding caching. Thanks for the help!
JLLeitschuh
merged commit a1d111e
into
JLLeitschuh:chore/JLL/advanced_codeql
No description provided.